aws/aws-pdk

[BUG] licensed: false setting does not work as expected.

Closed this issue · 1 comments

Describe the bug

In a projen project when the following flag is used
licensed: false
then the package.json file is updated as
"license": "UNLICENSED"
and the default LICENSE file in the directory is removed.

However, PDK based project does not remove the LICENSE file from the project.

Expected Behavior

Using the flag should have the following impact
the package.json file is updated as
"license": "UNLICENSED"
and the default LICENSE file in the directory is removed.

Current Behavior

The default LICENSE file in the directory is removed.

Reproduction Steps

Create a PDK project
use the flag
licensed: false

synth the project by running pdk command.

Possible Solution

Don't use PDK, use Projen.

Additional Information/Context

No response

PDK version used

0.23.33

What languages are you seeing this issue on?

Typescript

Environment details (OS name and version, etc.)

Mac

Hi @mtahir-cloudkitect,

We recently introduced a capability in PDK to disable licenses from being generated for all subprojects (by default they all get an Apache-2.0 license).

On the monorepo, if you add this it should solve your issue: licenseOptions: {disableDefaultLicenses: true}.

Here is the original PR that adds default licenses if interested: ab8e648