Unable to compile SDK with older windows SDK
ShimYama opened this issue · 6 comments
Describe the bug
I tried to build the latest SDK (1.11.329) but this line cause error and I can't build it.
I changed SDK version to 1.11.296 that the version before the line added, I can compile SDK.
Expected Behavior
Compile SDK
Current Behavior
Error occurs that tells me "WINHTTP_OPTION_ENABLE_HTTP_PROTOCOL" is not defined.
I checked the source and found that there's no such variable in my winhttp.h source.
I think I'm using Visual Studio 2017 and my windows sdk is too old.
Reproduction Steps
I used command prompt with this command.
cmake [AWS SDK Git Directory] -G "Visual Studio 14 Win64" -DCMAKE_BUILD_TYPE=Release -DBUILD_ONLY="S3;S3-crt;sts" -DENABLE_TESTING=OFF -DCMAKE_INSTALL_PREFIX=[Install Directory] -DBUILD_SHARED_LIBS=OFF -DFORCE_SHARED_CRT=OFF -DAWS_SDK_WARNINGS_ARE_ERRORS=OFF
msbuild INSTALL.vcxproj /p:Configuration=Release /t:Rebuild /m /nologo
Possible Solution
No response
Additional Information/Context
No response
AWS CPP SDK version used
1.11.329
Compiler and Version used
Visual Studio 2017
Operating System and version
Windows 10 Pro 22H2
should be fixed with #2967
Greetings! It looks like this issue hasn’t been active in longer than a week. We encourage you to check if this is still an issue in the latest release. Because it has been longer than a week since the last update on this, and in the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please feel free to provide a comment or add an upvote to prevent automatic closure, or if the issue is already closed, please feel free to open a new one.
Sorry for not responding.
I tested latest but another error occurred.
'ERROR_WINHTTP_CLIENT_AUTH_CERT_NEEDED_PROXY' and 'ERROR_WINHTTP_SECURE_FAILURE_PROXY' used in WinHttpSyncHttpClient.cpp are not defined.
However, it seems that these lines are added a few days ago, so should I report as another issue?
Sorry the first PR didn't fix it for you. @SergeyRyabinin's most recent PR should get it working for you. Please let us know if you still have any problems compiling this sdk
I tested latest and confirm it is okay. Thank you.
This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.