aws/http-desync-guardian

Cannot compile C samples

q2ven opened this issue · 3 comments

q2ven commented

In order to compile C samples, we have to fix two problems below.

1. Lack of http_desync_guardian_macros.h in the repository.

It seems that the header file has not been uploaded yet.

2. Typo in analyze_raw_request.c

This part

#incldesync_ude "http_guardian_macros.h"

should be

#include "http_desync_guardian_macros.h"
xnuter commented

Thanks for pointing this out. Both #include "http_desync_guardian_macros.h can be deleted.

Matthias247 commented

@xnuter It seems like it would be worthwhile to also set up CI for all the C parts, to avoid issues like these?
I however don't don't know how complicated this is with github actions .
Compiling with a single compiler is probably a good start to capture the basics - it doesn't have to check all platforms.

xnuter commented

I agree, it might be a good idea to add validation for the demo C code.
On the other hand, it's demo files that are not expected to change more often than the library API. So we can leave it for now and require manual validation on PR for such changes.