aws/porting-assistant-dotnet-visual-studio-ide-extension

LSP client performing an invalid cast

Closed this issue · 1 comments

davkean commented

Folks, I'm from the Visual Studio reliability team at @ Microsoft. Our telemetry has caught an issue where Porting Assistant extension is performing an invalid cast here:

porting-assistant-dotnet-visual-studio-ide-extension/src/PortingAssistantExtensionClientShared/PortingAssistantLanguageClient.cs

Line 275 in 1edd8fd

return (Task<InitializationFailureContext>)Task.CompletedTask;

This issue has been hit almost 200,000 times over the past 21 days, sometimes hundreds a times a Visual Studio session.

Unable to cast object of type 'System.Threading.Tasks.Task' to type 'System.Threading.Tasks.Task`1[Microsoft.VisualStudio.LanguageServer.Client.InitializationFailureContext]'

Please change this code to something like:

InitializationFailureContext initializationFailureContext = new()
{
    FailureMessage = ...
};
        
return Task.FromResult<InitializationFailureContext?>(initializationFailureContext);
pranav-firake commented

Thanks David for identifying above issue. We are looking into fixing it.

  • ❤️1