aws/session-manager-plugin

install tries to run a "start" command and uninstall tries to run a "stop" command

scott-doyland-burrows opened this issue · 3 comments

On installing the plugin I see this - note the error on the last line:

doylands@HGRSDELTCG30106:~$ sudo dpkg -i session-manager-plugin.deb
Selecting previously unselected package session-manager-plugin.
(Reading database ... 84984 files and directories currently installed.)
Preparing to unpack session-manager-plugin.deb ...
Preparing for install
/var/lib/dpkg/tmp.ci/preinst: 4: stop: not found
Unpacking session-manager-plugin (1.2.398.0-1) ...
Setting up session-manager-plugin (1.2.398.0-1) ...
Starting session-manager-plugin
/var/lib/dpkg/info/session-manager-plugin.postinst: 4: start: not found

Looking at /var/lib/dpkg/info/session-manager-plugin.postinst it shows this:

echo "Starting session-manager-plugin"
if [ $(cat /proc/1/comm) = init ]
then
    start session-manager-plugin || true
elif [ $(cat /proc/1/comm) = systemd ]
then
    systemctl enable session-manager-plugin
    systemctl start session-manager-plugin
    systemctl daemon-reload
fi
if [ -f /usr/local/bin/session-manager-plugin ]
then
    rm /usr/local/bin/session-manager-plugin
fi
ln -s /usr/local/sessionmanagerplugin/bin/session-manager-plugin /usr/local/bin/session-manager-plugin

It is trying to run a start command as my system is using init, but this does not exist.

Same sort of issue happens on uninstall due to this file containing a stop command:

/var/lib/dpkg/info/session-manager-plugin.prerm

Hi @scott-doyland-burrows,
Thanks for the reporting this issue, this script currently support using systemd start/stop command as it is a preferred way in Ubuntu.
Would you mind share your OS info and the command work for your system to help us reproduce it.
We already backlog this issue, but it may not be set in high priority pool. Not sure had you been unblocked, I find a similar one on web, snoyberg/keter#132, hope it will be helpful in your case.
We will try to find a stable fix for this, and not impact current customers. Appreciate for your info!

Thanks,
Yangtao

Hi @scott-doyland-burrows, Thanks for the reporting this issue, this script currently support using systemd start/stop command as it is a preferred way in Ubuntu. Would you mind share your OS info and the command work for your system to help us reproduce it. We already backlog this issue, but it may not be set in high priority pool. Not sure had you been unblocked, I find a similar one on web, snoyberg/keter#132, hope it will be helpful in your case. We will try to find a stable fix for this, and not impact current customers. Appreciate for your info!

Thanks, Yangtao

Hi,

I am using Ubuntu on Windows Subsystem for Linux which does not uses systemd.

However, the start command itself is not valid even on a non-systemd distro as far as I know.

It is not causing any issues as such, just an error when installing and uninstalling (the plugin still works), so I wasn't even sure what the startup was for.

Scott

Thanks! Glad to know it not blocking anything and that is a good point, I think we can remove some of these unnecessary step. After the package is unpacked and there is symlink under bin folder, it should already ready to be called by AWSCLI.