aws4embeddedlinux/meta-aws

commit squashing

jwinarske opened this issue · 2 comments

Any reason why my contribution commits for (rust recipes) were squashed? It no longer lists me as a contributor.

I do not know where it got lost, however I almost certainly personally made the change and I'd like to apologize.

I have removed the ability to squash in the github interface and rewritten our release process to use FF-only merges to prevent this and other issues.

We will be publishing our release process changes for transparency in the near future.

Your commits still exist. For example the firecracker commit still has you as the author and committer:

commit 9ffc457bfef227e4d5d1439bfe9242e250f14303
Author:     Joel Winarske <joel.winarske@linux.com>
AuthorDate: Sun May 23 21:31:08 2021 -0700
Commit:     Joel Winarske <joel.winarske@linux.com>
CommitDate: Tue May 25 20:08:30 2021 -0700

    Firecracker and Jailer via dynamic rust-layer

    Signed-off-by: Joel Winarske <joel.winarske@linux.com>

I'm not sure how github identifies the author in it's UI, but perhaps it's related to the GPG key sign-off or the email address?