awslabs/amazon-kinesis-client-nodejs

Graceful Shutdown of Workers

leamarty opened this issue · 4 comments

leamarty commented

Since September 30, 2016, there's a new method in KCL's library (for Java) that handles very well the shutdown. Its called "requestShutdown", and it has already been implemented there.

awslabs/amazon-kinesis-client#109

We are missing that method here in Node... when KCL decides to shutdown a worker, how can we handle and perform a Graceful Shutdown? Meaning that would be cool to let the worker to finish processing the current batch, then checkpoint, and only then start the shutdown.

pfifer commented

Currently graceful shutdown isn't supported for the MultiLang daemon clients at this time. We would like to bring support for the feature to the MultiLang daemon, and are prioritizing the feature against other feature requests.

To assist us with prioritizing this, could anyone else affected please post a reaction or comment.

  • 👍10
kingchad commented

This should definitely be added as soon as possible.

  • 👍2
AaronHarris commented

It appears aws-kcl v1.7.6 Added support for graceful shutdown in MultiLang Clients. @pfifer When will we see a new npm version cut that uses version ^1.7.6 which should hopefully fix this issue? Currently master points to v1.7.6 but might as well update to v1.8.0 before cutting a new npm version.

pfifer commented

The changes on the node.js side have been merged in as part of #39

We have an additional change for allowing processRecords calls to be timed out that is coming, and intend to release the two changes together.