awslabs/aws-embedded-metrics-python

Disallow duplicate dimension sets

markkuhn opened this issue · 2 comments

markkuhn commented

Related issues:

Currently duplicate dimension sets are being allowed.
Example:

metrics.put_dimensions({"Region": "us-east-1"})
metrics.put_dimensions({"Region": "us-east-2"})

This creates:

"Dimensions": [
  [
    "LogGroup",
    "ServiceName",
    "ServiceType",
    "Region"
  ],
  [
    "LogGroup",
    "ServiceName",
    "ServiceType",
    "Region"
  ]
]

When it should be:

"Dimensions": [
  [
    "LogGroup",
    "ServiceName",
    "ServiceType",
    "Region"
  ]
]
gordonpn commented

Should there be an issue for the dotnet library as well?

markkuhn commented

@gordonpn It is indeed an issue in the dotnet library as well. Creating an issue for it.

  • 👍1