awslabs/datawig

SimpleImputer.complete fails when output_path is not the default, i.e. not "."

angeliney opened this issue · 3 comments

angeliney commented

shutil.rmtree(output_col) in SimpleImputer.complete fails because the directories are generated within the output_path. The code should have been shutil.rmtree(os.path.join(output_path, output_col))

felixbiessmann commented

Thanks a lot for catching this! We'll look into this asap, but in case you're faster with wrapping this in a pull request, we'd be happy to just approve it.

  • 👍1
angeliney commented

Great, thank you for the quick response! Made a pull request here: #130

tdhd commented

Closing issue as #135 is merged now.