awslabs/duvet

Unexpected trimming to the spec

eagr opened this issue · 2 comments

eagr commented

Using the quote (copied exactly as is from the spec) for annotation

[[TODO]]
quote = '''
A CONNECT request MUST be constructed as follows:

*  The :method pseudo-header field is set to "CONNECT"

*  The :scheme and :path pseudo-header fields are omitted

*  The :authority pseudo-header field contains the host and port to
   connect to (equivalent to the authority-form of the request-target
   of CONNECT requests; see Section 7.1 of [HTTP]).
'''

raised an error.

specs/rfc9114/todos/4.4.toml#0:0 - quote not found in "https://www.rfc-editor.org/rfc/rfc9114#section-4.4"

Then I tried gradually removing the whitespace. And this works.

[[TODO]]
quote = '''
A CONNECT request MUST be constructed as follows:

*  The :method pseudo-header field is set to "CONNECT"
*  The :scheme and :path pseudo-header fields are omitted
*  The :authority pseudo-header field contains the host and port to connect to (equivalent to the authority-form of the request-target of CONNECT requests; see Section 7.1 of [HTTP]).
'''

Is there some kind of trimming going here for the spec before search? If so, is this the intended way to use quotes like this?

Looks like a bug. Citations should ignore whitespace entirely when matching.

eagr commented

quote: self.quote.trim().replace('\n', " "),

This may be the culprit, as it doesn't trim the quotes by line.