[Bug] Max concurrent uploads flag is unused
austinvazquez opened this issue · 2 comments
Description
Follow-up to #1113, where it was found the max-concurrent-uploads flag can be set but is never read. The result is the default concurrent limit of 3 is used (defined by oras-go library ref)
Steps to reproduce the bug
Push SOCI index to registry with --max-concurrent-uploads != 3.
Describe the results you expected
As a user, I expect this flag to be honored by the soci push command.
Host information
- OS: Amazon Linux 2023 x86_64
- Snapshotter Version: soci version 7af8577 7af8577
- Containerd Version: containerd github.com/containerd/containerd v1.6.28 ae07eda36dd25f8a1b98dfbf587313b99c0190bb
Any additional context or information about the bug
No response
Hm, I thought we had an issue for this but closest we have is #677, which is tangentially related, and #872, which is for our config files.
We have a lot of flags and config variables that we inherited from stargz that go unused. Some effort to identify unused variables would be helpful in reducing confusion here (e.g. #839).
Hm, I thought we had an issue for this but closest we have is #677, which is tangentially related, and #872, which is for our config files.
We have a lot of flags and config variables that we inherited from stargz that go unused. Some effort to identify unused variables would be helpful in reducing confusion here (e.g. #839).
I see I was curious what could have happened here, but also pretty understandable it went unnoticed as the focus for SOCI is improving image pull time. Who knows? Maybe this will inadvertently make someone's day better or at least not worse. :)