axieinfinity/ronin-dpos-contracts

Potential bugs in `isValidator` callers

nxqbao opened this issue · 1 comments

nxqbao commented

Potential problems in calling isValidator.

contracts/ronin/Maintenance.sol:

  • Does we allow a candidate to schedule maintenance? Because an arbitrary candidate may not know if they will be picked to become a validator in the future. In the current implementation, we don't have any time restriction on the _startedAtBlock.

contracts/ronin/SlashIndicator.sol:

  • Same for the Maintenance contract. In case a misbehaved ex-validator becomes a candidate, we cannot slash him since he is not a validator anymore.

Originally posted by @nxqbao in #32 (comment)

nxqbao commented

That's ok for delegators to continue delegating.