axiel7/AniHyou-android

F-Droid reproducible build failed

Closed this issue · 26 comments

linsui commented

Describe the bug (required)
1.2.4 is not reproducible. Is the apk built from 9191aab?

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Enviroment (required)

  • Device model:
  • Android version:
  • App version:

Additional context (optional)
Add any other context about the problem here.

axiel7 commented

Mmm yeah the apk was compiled from that commit. I'll replace the files just in case.

Where can I see the pipeline log?

axiel7 commented

I just updated the fastlane changelog today because I forgot to do it before the 1.2.4 tag. So maybe it's compiling from that commit?

linsui commented 
2024-01-18 07:31:44,769 DEBUG: > git checkout -f 9191aab5e2a58f27b3a5e0e4b3174580ac0756df

We build the apk from the tag. And your apk is also uploaded 3 days ago...

axiel7 commented

So I don't understand then. I just compiled and reuploaded the apks built from 9191aab. Could you re run the pipeline?

linsui commented

It's not reproducible... How do you build the apk?

axiel7 commented

I'm building the same as always, release build and signing with the same keystore. Maybe some updated dependency is causing the issue?

I updated gradle to 8.5 and AGP to 8.2.1

axiel7 commented

It seems this may be related?

For reference, I'm building the apk on macOS (as always) with Android Studio 2023.1.1 Patch 1

linsui commented

I thought the new line issue is not related. The diff is very large so that I have no idea what happened. Maybe the jdk is different. We use openjdk 17. The AS may cause problem. And maybe you need to clean the cache.

axiel7 commented

I'm using the jdk built-in AS with version 17.0.7. I just cleaned cache, built and reuploaded the apks.

axiel7 commented

So I just tried running diffoscope and these are the results. It's seems the main differences are the META-INF files. Any idea what could be causing this?

axiel7 commented

I just uploaded a new build and the pipeline passed.

What I did was update to Java 11 and disable resource shrinking. I'm still don't know why the previous version was reproducible because it used Java 8 and resource shrinking...

linsui commented

Great! f40157c This workground workd for some other apps too. I don't know how it works though.

axiel7 commented

@linsui sorry for the mention. But since the 1.2.4 tag didn't pass the pipeline, do I need to do something to trigger the 1.2.4-1 update? It has been more than 7 days since I created the 1.2.4-1 tag

axiel7 commented

Oh okay, I read some forum posts mentioning that it should take 2-3 days but I wasn't sure. Thank you!

axiel7 commented

Mmm I'm not sure what could be the issue now. Maybe the upgrade of AGP from 8.2.1 to 8.3.1? Also I'm using KSP now instead of KAPT

axiel7 commented

I uploaded a new 1.2.5-1 build compiled using GitHub Actions with ubuntu-latest and the pipeline is now passing.

Maybe the issue was related with the recent Java bugs in the latest macOS 14.4, idk.

I opened a MR to re enable AniHyou.

linsui commented

It failed again https://monitor.f-droid.org/builds/log/com.axiel7.anihyou/75#site-footer but I can't reproduce it in the CI https://gitlab.com/linsui/fdroiddata/-/jobs/7228745450. Maybe it's an issue of the cpu number. Maybe something is not deterministic.

axiel7 commented

Probably it has something to do with baseline profiles since I implemented it in the latest release. I'll investigate

linsui commented

I can't reproduce the problem in buildserver. No idea. Let's see if it builds in the next cycle.

  • 👍1
licaon-kter commented

reopen, you've tagged https://github.com/axiel7/AniHyou-android/releases/tag/1.3.4 from 466f418 but the APK is built from 5a26616 ?

ref: https://gitlab.com/fdroid/fdroiddata/-/jobs/7468833911

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/4c826702cee88b84eefbe2ff3023c96faa18ef98

/LE: trying that out of tree commit:

DEBUG: Directory: build/com.axiel7.anihyou
DEBUG: > git checkout -f 5a26616421974db5dbe4bd5159cdcb588c8a98bc
ERROR: VCS error while building app com.axiel7.anihyou: Git checkout of '5a26616421974db5dbe4bd5159cdcb588c8a98bc' failed
axiel7 commented

My fault, sorry. I forgot to include the changelog txt so I deleted and recreated the tag because I assumed that file wouldn't cause any diff.

I compiled the apks from 466f418 and reuploaded them to the 1.3.4 release. I think that should be enough.

linsui commented

It won't cause diff if you disable the vcs info. See https://f-droid.org/en/docs/Reproducible_Builds/#vcs-info.

  • 👍1