axieum/authme

Modrinth description has incorrect HTML in `<img>` tag

James103 opened this issue · 2 comments

Expected behavior

In the Modrinth description, there should be a GIF showing some of the possibilities of the Auth Me mod.

The relevant raw HTML should be as follows:

<img alt="Auth Me Demo" src="https://github.com/axieum/authme/raw/main/demo.gif" width="50%" align="right">

Observed/actual behavior

The above HTML is incorrectly typed and displays as is:

<img alt="Auth Me Demo" src="https://github.com/axieum/authme/raw/main/demo.gif" width="50%" align="right>

(missing double quotes " near the end).

Steps/models to reproduce

Check the Modrinth description for the mod: https://modrinth.com/mod/auth-me

Version

authme-7.0.2+1.20.jar (assumed latest)
Issue is with mod description, accessed 7 July 2023.

Agreements

  • I am running the latest version of the mod.
  • My version of Minecraft is supported.
  • I have searched for and ensured there isn't already an open issue regarding this.

Other

No response

axieum commented

Thank you for pointing this out. I've gone ahead and manually updated it, however it will break again on the next release.

authme/build.gradle

Lines 217 to 218 in a1f44fd

// Set the project body sync target
syncBodyFrom = rootProject.file('README.md').getText()

I wonder if Minotaur is preprocessing relative links in the markdown?

axieum commented

Minotaur mentions this:

This does not occur with the modrinth task; you must use the modrinthSyncBody task separately to accomplish this.