axiosvisuals/Chartbuilder

update Chartbuilder to 3.0.1 & port styles

Opened this issue · 3 comments

newsroomdev commented

After speaking with David Yanofsky at Quartz, it's clear that Chartbuilder v3 will help us more easily make requested tweaks to Chartbuilder. However, that means porting over all of our styles to the latest version.

I've started this process in dev branch with d9ba6cf, but will need @duner's help to re-implement some of the custom styles and redesigns he implemented.

@duner let me know if this is too messy. If so, we can pair-program resolving merge conflicts so I don't remove any of your style tweaks.

  • re-implement Axios styles:
    • add gridlines back #1
    • right align labels #3
    • font styles — monospace for subhead, gordita for the rest, also font sizes, anti-aliasing #6
    • colors #5
    • subhead #7
    • margins #8
    • aspect ratios #10
newsroomdev commented

EOD 02/08/2017 note for @duner:

Made a ton of progress on #1, #5, and #7. Could do a git pull and close out #5 and #6 if those fonts and colors look good?

Next steps:

  • Right align labels so the left symbol hangs #3
  • Double check margins with design team. (v2 margins != v3 margins) #8
duner commented

@geraldarthur This is awesome! I'm going to take a look at #6 and make a couple fixes here (gotta anti-alias some things I think and double check the font sizes). I reopened #7 because it seems like there are some weird edge cases. (But it's mostly there!)

Do we want to temporarily disable some of those mobile options/previews as they don't actually work yet given our setup?

duner commented

#1 and #5 look good to me though — I'll double check with Laz and Andrew to make sure the colors are right.