axone-protocol/axoned

👷🏼 Upgrade golangci-lint to the latest version

Closed this issue · 3 comments

ccamel commented

Purpose

The current version of golangci-lint used in this repo is quite old (v1.56). It would be beneficial to update to the latest available version to take advantage of the latest improvements, bug fixes, and features.

Suggested action:

  • Update golangci-lint to the latest stable version.
  • Update the codebase if the linter requires any changes.
dangogh commented

working on this

  • ❤️1
dangogh commented

question: a number of gosec:G115 warnings (potential int conversion overflow). Should be able to safely ignore (many of) these, but opinion on how this project wants to handle them?

ccamel commented

@dangogh That’s a great question. I agree that not all G115 warnings can be properly addressed (for now), and it makes sense to disable them on a case-by-case basis. From what I can see, you’ve already handled this appropriately in the commit f903d5f, so this approach looks good to me. 👍