aykamko/tag

Support for ripgrep

Closed this issue · 12 comments

kevinjalbert commented

I recently saw ripgrep pop up as the new fast search tool. I see that #22 is considering adding support for pt, via possibly a TAG_PROG environment variable.

I haven't looked too deeply into the format differences between ag vs ripgrep. I figure I could make the issue incase someone wants to take a stab at it?

aykamko commented

I've actually been wanting to support ripgrep lately too. I don't have much bandwidth to implement it myself right now, but I'll probably have some time around Thanksgiving (so end of November-ish).

Thanks for making this issue! Hopefully someone else can jump on it before I can. :)

  • 👍3
andylima commented

I'm really looking forward to this getting in, too. 👍

joaosa commented

I'm also pretty interested in this too :)

aykamko commented

Update: Starting work on this today, hoping to get this out before xmas!

  • 🎉3
YPCrumble commented

@aykamko I'd be happy to update my PR #30 to also work using the --files flag for ripgrep which I think would be the equivalent scenario.

joaosa commented

@aykamko any news on this? :)

  • 👍1
aykamko commented

finally got around to this: #40

will be updating the docs and making a new release today. will close this issue after that.

  • 🎉2
kevinjalbert commented

@aykamko I wonder if the brew tap should be updated to account for new releases (brew tap is pointing to 1.2.1 still).

https://github.com/aykamko/homebrew-tag-ag/blob/master/tag-ag.rb#L1

aykamko commented

@kevinjalbert yup, gonna update this now, apologies for the delay

aykamko commented

brew tap is updated 😁

  • 👍1