aysylu/loom

default-flygraph-digraph-impl has error, nil protocol method impl

cemerick opened this issue · 1 comments

While working out making loom Clojure[Script]-portable, I came across this:

:in-edges (get-in default-digraph-impl [:all :in-edges])

default-digraph-impl has no value at [:all :in-edges]. I presume this should be (get default-digraph-impl :in-edges).

I'm not going to make this change, though: the tests are passing as-is, so flygraph digraphs are apparently not covered, and I have no use for flygraphs currently, so I'm not in a position to write those tests.

Good catch. Thanks for reporting the issue, @cemerick!