Make it configurable to send zero values

Question

Make it configurable to send zero values

marcelboettcher opened this issue 7 years ago · 8 comments

Hey Alexander,

first of all: Great work, exactly what I was looking for! Thx!

I would love to see a builder option to send zero values, which isn't done at the moment to save costs. That makes sense, but for our use case we would like to see zeros as well as we would interprete missing values as possible error in the monitoring system.

What do you think? Does this make sense for you?

All the best from Germany
Marcel

Answer 1 · 2017-12-15T17:21:15.000Z

@marcelboettcher hello! Thank you for the kind words. I can look into it and add an option of sending zeroes. I will issue a PR and if you could build locally and test it, would be great.. Thoughts?

Answer 2 · 2017-12-15T17:23:51.000Z

Perfect! I will test it.

On Fri 15. Dec 2017 at 18:21, Alexander Zagniotov ***@***.***> wrote: @marcelboettcher <https://github.com/marcelboettcher> hello! Thank you for the kind words. I can look into it and add an option of sending zeroes. I will issue a PR and if you could build locally and test it, would be great.. Thoughts? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFmMPP1Ua-N1mdDtVnA3XTIXmwlIrHwdks5tAqqLgaJpZM4RDrn4> .

-- Viele Grüße Marcel Mobil 0162 / 36 20 374 mail@marcelboettcher.de

Answer 3 · 2017-12-16T06:41:19.000Z

@marcelboettcher btw, I thought to point your attention to one of the closed issues: #4 @ben-manes has observed an exception happening when submitted values were zero.

Answer 4 · 2017-12-16T07:07:36.000Z

Hi @marcelboettcher Please have a look at my PR: #9 and you can try building an artifact from the following branch: zero_values_submission. If it does what you need, I will push a release to Maven Central

Answer 5 · 2017-12-16T14:35:12.000Z

Hi @azagniotov,
thanks a lot for the quick adjustment!
I tested withZeroValuesSubmission() successfully for counters and a histograms with snapshot size > 0 (so an active one).

An inactive histogram (snapshot size == 0) does report count and the three percentiles correctly, but fails with the mentioned InvalidParameterValueException for arithmeticMean, stdDev and statisticSet.

So I would propose to move the snapshot.size() > 0 check around those metric types only. Please check my PR #10

Answer 6 · 2017-12-17T07:13:47.000Z

Hi @marcelboettcher , v1.0.6 has been released. Please wait a few hours until Maven Central syncs .

Thank you for your help!

Answer 7 · 2017-12-18T07:54:55.000Z

Hey @azagniotov, thank you!
But it does not show up on Maven Central. The version in gradle.properties is still 1.0.5 by the way.

Cheers

Answer 8 · 2017-12-18T08:00:35.000Z

@marcelboettcher , It is there on Maven: https://search.maven.org/#artifactdetails%7Cio.github.azagniotov%7Cdropwizard-metrics-cloudwatch%7C1.0.6%7Cjar ... Sorry, I released from the branch . instead of the master. Will merge to master right now