Windows installation guide links to download Visual Studio 2022 but Boost supports up to 2019
Synful-Syn opened this issue · 8 comments
Describe the bug
The requirements of the Windows installation guide (git link) asks to install Visual Studio (16) Community 2019 but the download link leads to 2022 and its default MSVC is v143 but Boost (1.78, the latest) supports up to v142.
On the linked page, it does mention about 2019 but it is a download link for Mac.
To reproduce
Pretty much follow the guide on a clean Windows 10 but I choose Boost 1.78 because I could.
Expected behavior
A clear and concise description of what I should do without doing any extra steps in order to achieve a working local AzerothCore on my computer.
Screenshots
View the Additional context part.
Desktop:
- Windows 10 x64
- Firefox
Additional context
TLDR: I simply had a new computer so I am re-doing the setup and this is my analysis on how to I managed to compile with Visual Studio by saying "compile the way Visual Studio 2019 would do".
Fast forward in the core installation, in Visual Studio 2022, I did "Regenerate" on ALL_BUILDS in the Solution Explorer, I then I had these errors.
(impossible to open the file boostlib_filesystem-vc143-mt-x64-1_78.lib)
I've noticed the error messages were very similar to what I've previously seen in CMake. However, the error was looking for v143 while Boost, the latest version available is v142.
Luckily, I did remember seeing that by default, Visual Studio 2022 Community installs MSCV v143 and I have chosen to modify my Visual Studio so I would also have the v142.
It did not fix my issue, but I've understood it was still trying to use MSVC v143 by default. After some extensive research, I've found out that in the Solution Explorer, you can get into the properties of a solution and tell it to use v142 instead and I tried on one of the projects: one of the 2 messages were gone so I knew if all of them were on v142, it would finally be fixed.
Don't use Boost 1.78
Rofl, just look this
@Synful-Syn for v143 need lib64-msvc-14.3
Oh, thank you for the link, I don't know how I missed it!
I still think the Windows installation guide is still missing a few points.
As I firstly mentionned, the download link for Visual Studio (16) Community 2019 leads to 2022 and I cannot find where to download 2019 (but I still have managed to get my server up and running using Visual Studio 2022 compiled with MSVC 143 and the 1.78 MSVC 143 Boost link above).
For the second, let's begin with how the page layout currently is.
On point i, it says Download the prebuilt Windows Binary for Visual Studio 2019. What is it? Is it the link on either point iii or point iv or is it something I can find in the Visual Studio Installer?
On points iii and iv, they leads to a MSVC 142 but as I said, the Visual Studio download link leads to a version that has MSVC 143 which is a mismatch.
I propose to change the layout about the Boost section to be the following.
The website link has been moved after the recommended download links in order to prevent the situation of missing the recommended download links by clicking the very first link available.
The recommended download links also shows which link supports which version of Visual Studio between 2019 and 2022.
@Synful-Syn lib64-msvc-14.3 only in boost 1.78.0
After start cmake support boost 1.78.0 (next release) we can change guide
CMake Warning at C:/Program Files/CMake/share/cmake-3.22/Modules/FindBoost.cmake:1369 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
C:/Program Files/CMake/share/cmake-3.22/Modules/FindBoost.cmake:1492 (_Boost_COMPONENT_DEPENDENCIES)
C:/Program Files/CMake/share/cmake-3.22/Modules/FindBoost.cmake:2102 (_Boost_MISSING_DEPENDENCIES)
deps/boost/CMakeLists.txt:35 (find_package)
CMake Warning at C:/Program Files/CMake/share/cmake-3.22/Modules/FindBoost.cmake:1369 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
C:/Program Files/CMake/share/cmake-3.22/Modules/FindBoost.cmake:1492 (_Boost_COMPONENT_DEPENDENCIES)
C:/Program Files/CMake/share/cmake-3.22/Modules/FindBoost.cmake:2102 (_Boost_MISSING_DEPENDENCIES)
deps/boost/CMakeLists.txt:35 (find_package)
CMake Warning at C:/Program Files/CMake/share/cmake-3.22/Modules/FindBoost.cmake:1369 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
C:/Program Files/CMake/share/cmake-3.22/Modules/FindBoost.cmake:1492 (_Boost_COMPONENT_DEPENDENCIES)
C:/Program Files/CMake/share/cmake-3.22/Modules/FindBoost.cmake:2102 (_Boost_MISSING_DEPENDENCIES)
deps/boost/CMakeLists.txt:35 (find_package)
CMake Warning at C:/Program Files/CMake/share/cmake-3.22/Modules/FindBoost.cmake:1369 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
C:/Program Files/CMake/share/cmake-3.22/Modules/FindBoost.cmake:1492 (_Boost_COMPONENT_DEPENDENCIES)
C:/Program Files/CMake/share/cmake-3.22/Modules/FindBoost.cmake:2102 (_Boost_MISSING_DEPENDENCIES)
deps/boost/CMakeLists.txt:35 (find_package)
CMake Warning at C:/Program Files/CMake/share/cmake-3.22/Modules/FindBoost.cmake:1369 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
C:/Program Files/CMake/share/cmake-3.22/Modules/FindBoost.cmake:1492 (_Boost_COMPONENT_DEPENDENCIES)
C:/Program Files/CMake/share/cmake-3.22/Modules/FindBoost.cmake:2102 (_Boost_MISSING_DEPENDENCIES)
deps/boost/CMakeLists.txt:35 (find_package)And you can start make PR If you want