`material-ui-icons` is too big

Question

`material-ui-icons` is too big

gimdongwoo opened this issue 7 years ago · 6 comments

gimdongwoo commented 7 years ago

Thank you.

Fisrt of all, object-editor-react is a great components!

But, object-editor-react need to tree shaking.

Answer 1 · 2018-05-13T10:01:13.000Z

Thanks for opening an issue @gimdongwoo.

I'll look into the bundle size. What tool did you use to generate this visualization?

Answer 2 · 2018-05-13T10:09:47.000Z

Here :)
https://www.npmjs.com/package/webpack-bundle-analyzer

And, this warning is appeared on build.

npm WARN deprecated material-ui-icons@1.0.0-beta.36: Use @material-ui/icons instead

Answer 3 · 2018-05-13T13:20:14.000Z

Just published a new version (1.0.4) that allows module bundlers to omit most of the icon modules.

Here are the numbers (for a test project with just object-editor-react as a dependency):

One thing to keep in mind: the object-editor-react bundle only contains the object-editor-react source, so we can't do any additional tree shaking on the object-editor-react bundle itself.

Let us know if this reduces your bundle size :)

Answer 4 · 2018-05-13T13:24:09.000Z

Awesome!!

Thank you 👍

Answer 5 · 2018-05-13T13:32:42.000Z

[before]

[after]

I really appreciate your super fast response!

Answer 6 · 2018-05-13T13:40:29.000Z

Happy to hear this helped 😄 I've also got plans to improve the bundle even more in the future.

Going to close this for now but feel free to raise another issue if the bundle size is still giving you trouble.