b-zurg/react-collapse-pane

Missing definition for Nullable<T> in SplitPane/index.tsx

hst44 opened this issue ยท 10 comments

hst44 commented

Nullable is not defined in src/components/SplitPane/index.tsx which causes builds to fail when including a SplitPane via npm. Results in:

ERROR in ...\node_modules\react-collapse-pane\dist\components\SplitPane\index.d.ts
(8,35): error TS2304: Cannot find name 'Nullable'.
ERROR in ...\node_modules\react-collapse-pane\dist\components\SplitPane\index.d.ts
(34,22): error TS2304: Cannot find name 'Nullable'.

Oh! That's what I get for using a global type.

I'll fix that today. I think you should be able to get it working by using skiplibcheck in the tsconfig.json of your project.

๐ŸŽ‰ This issue has been resolved in version 1.3.9 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

@hst44 did the latest release resolve the issue?

hst44 commented

There isnt an error about Nullable anymore, but the change introduced a new error:

ERROR in ...\node_modules\react-collapse-pane\dist\components\SplitPane\index.d.ts
(2,26): error TS2307: Cannot find module '../../types/utilities' or its corresponding type declarations.

Thanks for reporting. The source of this issue was that *.d.ts files are not emitted during output. I'll rename the type declaration file to be a normal *.ts file and have a fix released in a sec.

hst44 commented

Great! thanks for the quick fix!

No worries :)

@all-contributors please add @hst44 for bug

@b-zurg

I've put up a pull request to add @hst44! ๐ŸŽ‰

Release v1.3.10

Please confirm if it fixes the issue

hst44 commented

All fixed. Thanks!