b-zurg/react-collapse-pane

Does collapseDirection work?

JeremyGrieshop opened this issue · 4 comments

JeremyGrieshop commented

I can't seem to get it to work with the collapseOptions. Codesandbox:

https://codesandbox.io/s/react-collapse-pane-down-hrov2?file=/src/App.js

godsamit commented

I think the prop name is changed to "collapse".

JeremyGrieshop commented

I think the prop name is changed to "collapse".

collapse tells it to show the collapse button. collapseDirection is supposed to control which direction.

image

godsamit commented

No... read the source code. the prop name has been changed.

react-collapse-pane/src/components/SplitPane/index.tsx

Line 46 in 8846709

collapse?: boolean | Partial<CollapseOptions>;

Also just tested on your codesandbox and it works

JeremyGrieshop commented

Ah, thank you, @godsamit. The documentation example shows otherwise (using collapseOptions object instead).

image