DataHandler hook resets "container parent" for children

[dmitryd]

What is the issue?

We set tx_container_parent in $TCA to read-only to prevent editors from changing containers using this form. TYPO3 does not generate hidden input fields for such fields and this causes the field not to be submitted by browsers. The hook in B13\Container\Hooks\Datahandler\DatamapBeforeStartHook checks if the field is set or not in the submitted data and if not, it sets the field to zero basically overwriting correct parent in the database.

Ideas for the fix

Much better behavior would be to find what the current value is and set it to data. Logically if the value is not set, it should not change. However if somebody decides to remove the parent, the value would be set and it would be zero. So current solution (to set it to zero if not set) is not logical and it corrupts the data.

How to reproduce?

Configuration/TCA/Overrides/tt_content.php:

$GLOBALS['TCA']['tt_content']['columns']['tx_container_parent']['config']['readOnly'] = true;

[dmitryd]

The issue is only for container 1.x. If anybody has the issue, the patch is here. Nothing needed for v2.

0002-PATCH-BUGFIX-Fix-362-DataHandler-hook-corrupts-conta.patch