b3nj5m1n/kommentary

Startup time question

benfrain opened this issue · 3 comments

I just started to profile my startup time and noticed that Kommentary (5th line down) seems to be the slowest of my plugins (profiled with nvim --startuptime vim.log). I'm not certain I'm reading the log correctly but I thought it was worth mentioning in case there is something causing the comparatively long time?

307.751  000.949  000.949: sourcing /Users/benfrain/.local/share/nvim/site/pack/paqs/start/auto-pairs/plugin/auto-pairs.vim
310.054  000.535  000.535: sourcing /Users/benfrain/.local/share/nvim/site/pack/paqs/start/auto-session/plugin/auto-session.vim
312.141  000.284  000.284: sourcing /Users/benfrain/.local/share/nvim/site/pack/paqs/start/formatter.nvim/plugin/formatter.vim
314.146  000.205  000.205: sourcing /Users/benfrain/.local/share/nvim/site/pack/paqs/start/hop.nvim/plugin/hop.vim
319.687  004.282  004.282: sourcing /Users/benfrain/.local/share/nvim/site/pack/paqs/start/kommentary/plugin/kommentary.vim
322.630  000.586  000.586: sourcing /Users/benfrain/.local/share/nvim/site/pack/paqs/start/lspsaga.nvim/plugin/lspsaga.vim
324.750  000.424  000.424: sourcing /Users/benfrain/.local/share/nvim/site/pack/paqs/start/minimap.vim/plugin/minimap.vim
326.613  000.450  000.450: sourcing /Users/benfrain/.local/share/nvim/site/pack/paqs/start/nvim-compe/plugin/compe.vim
328.496  000.319  000.319: sourcing /Users/benfrain/.local/share/nvim/site/pack/paqs/start/nvim-lspconfig/plugin/lspconfig.vim
332.206  002.279  002.279: sourcing /Users/benfrain/.local/share/nvim/site/pack/paqs/start/nvim-treesitter/plugin/nvim-treesitter.vim
333.411  000.028  000.028: sourcing /Users/benfrain/.local/share/nvim/site/pack/paqs/start/nvim-treesitter/ftdetect/gdscript.vim
333.769  000.023  000.023: sourcing /Users/benfrain/.local/share/nvim/site/pack/paqs/start/nvim-treesitter/ftdetect/gomod.vim
334.107  000.030  000.030: sourcing /Users/benfrain/.local/share/nvim/site/pack/paqs/start/nvim-treesitter/ftdetect/hcl.vim
334.445  000.032  000.032: sourcing /Users/benfrain/.local/share/nvim/site/pack/paqs/start/nvim-treesitter/ftdetect/query.vim
334.843  000.020  000.020: sourcing /Users/benfrain/.local/share/nvim/site/pack/paqs/start/nvim-treesitter/ftdetect/yang.vim
335.991  000.131  000.131: sourcing /Users/benfrain/.local/share/nvim/site/pack/paqs/start/nvim-web-devicons/plugin/nvim-web-devicons.vim
337.813  000.288  000.288: sourcing /Users/benfrain/.local/share/nvim/site/pack/paqs/start/plenary.nvim/plugin/plenary.vim
339.828  000.467  000.467: sourcing /Users/benfrain/.local/share/nvim/site/pack/paqs/start/targets.vim/plugin/targets.vim
342.216  001.139  001.139: sourcing /Users/benfrain/.local/share/nvim/site/pack/paqs/start/telescope.nvim/plugin/telescope.vim
344.756  000.902  000.902: sourcing /Users/benfrain/.local/share/nvim/site/pack/paqs/start/vim-closetag/plugin/closetag.vim
347.535  000.823  000.823: sourcing /Users/benfrain/.local/share/nvim/site/pack/paqs/start/vim-surround/plugin/surround.vim
349.794  000.910  000.910: sourcing /Users/benfrain/.local/share/nvim/site/pack/paqs/start/vim-vsnip/plugin/vsnip.vim

Hi, thanks for sharing, I'm also not sure if I'm reading the log correctly, but if we are, kommentary is definitely a little slow. (Although I think you don't really feel this when you're just using nvim normally)

Unfortunately, I'm not sure what could be causing this, but I also haven't actively worked on this for a while.

I might look into it at some point, but honestly I wouldn't get my hopes up. If anyone has an idea what could be causing this, please feel free to post here or send a PR.

any updates on this. Do you have any ideas where I should start looking? I have some spare time in the coming weeks, and it would be great to have this plugin load faster.

@ViRu-ThE-ViRuS
Sorry it took me so long to get back to you, unfortunately I won't be of much help. At this point it's been too long since I've last actively worked on this plugin, it would take me some time to get back into it.

I remember there being several things that could be optimized, however none of those things should really affect startup times, so that threw me off a bit.

If you have any more specific questions about the codebase, I'd be more than happy to help. (If you're still planning on working on this)