babel/generator-babel-boilerplate

Remove config data from package.json

Closed this issue · 9 comments

jamesplease commented

I originally put the boilerplate config in the package.json per @thejameskyle's suggestion. @megawac thinks it'd be better to put it in the gulpfile.

I'm fine either way, honestly. Any strong opinions here?

jamiebuilds commented

No strong opinions

jamesplease commented

@megawac what you think?

megawac commented

I'd like to see it moved elsewhere - probably just gulpfile IMO

jamiebuilds commented

Yeah the gulpfile is good

jamesplease commented

k will change

jamesplease commented

@thejameskyle / @megawac I think I've got three choices:

  1. leave it the way that it is
  2. duplicate the mocha globals in two places (Gulpfile and browserify setup file)
  3. create an external file just for the mocha configuration

Thoughts?

paulfalgout commented

4: I think you should have an external json file for the mocha globals and the eslintrc file in the test directory should extend from it so you're not setting them there as well.

jamesplease commented

I'm going to close this because of @paulfalgout 's awesome change made here ceb2941

If anyone else has any ideas for further ways to optimize the configuration, do let me know!