babel/generator-babel-boilerplate

Update docs regarding bundling external deps

Closed this issue · 3 comments

jamesplease commented

Just made a new project – my first third party lib in awhile – and it's pulling in a third party lib into the final build. Are you experiencing this @paulfalgout ?

ex.:

import Rx from 'rx';

// do stuff
jamesplease commented

Adding the externals option in webpack fixed it...but this wasn't required before, iirc. It's been some time since I've done this, though. @paulfalgout does this seem right to you?

jamesplease commented

It's entirely possible that I just haven't used the boilerplate for a lib like this since the switch to Webpack just a few months ago: https://github.com/babel/generator-babel-boilerplate/releases/tag/6.0.0

If this is the case, then I need to update the docs on requiring in third party modules. Also, this makes it a lot less convenient to use this boilerplate compared to not having to do anything to pull in third party libs.

jamesplease commented

Updated the issue to reflect that this needs to be changed in the docs until we switch to Rollup (#319)