babelshift/SteamWebAPI2

HttpClients not being handled correctly

dukeofsussex opened this issue · 1 comments

Great library, but diving into the code I found a lot of this:

HttpClient httpClient = new HttpClient();
// do something
return response;

The client isn't being disposed off, kept as a singleton or injected using the factory pattern.

I have no clue whether this causes any issues though, just a heads up.

Fixed with #73