babylonchain/networks

Collect PR failures data on finality provider registration to improve guide

RafilxTenfen opened this issue · 1 comments

Gather information about PR's failures to create action items and improve finality provider registration guide

Failures

1. Signed json is not exactly the same

The json file with the finality provider registration info is used to generate a signature with eotsd sign-schnorr and when the PR is open instead of using the same file, just the content is being pasted to Git Hub.

Cases: #29, #47, #55, #59, #66, #67, #72, #74, #75, #85 .. #92, #125, #133, #147, #157, #166, #188

Add explicit instruction to use the same file signed to open the pull request in the guide

2. Bad covenant-comittee-pks

The covenant-comitte-pks used is not the lock only specified in the guide, but rather used the example on the docs for btc-staker

Cases: #31

Create a commit on reference repositories with examples that match the values recommended in the registry guide.

3. Diff fp pk tx and file

The finality provider public key specified in the registration file does not match the one used to create the transaction

Cases: #77, #152, #156, #165

Create a commit on reference repositories with the example that uses <fp_pk> as instruction instead of the example fp_pk as it can confuse the user

4. Staking amount different than required

The lock amount set on the tx was different than the one specified. If the specified amount is higher, all good, the registration can proceed, if it is lower than the specified it needs to create the deposit transaction again.
Cases: #39, #58, #62, #107

Higher already solved by using flag of --min-staking-amount on the verification
Lower, we need to be explicit in the guide that if it is lower than the specified it will not be a valid registration.

5. Not enough BTC confirmations

The pull request with the BTC tx self-lock deposit does not have enough confirmations
Cases: #44, #66, #113

Add script to verify the modified files if it is an FP registration, Make sure it has at least 6 confirmations

6. Did not provide a signature

The created pull request only contained the json information, missing the signature
Cases: #50

CI fail warning about missing file

7. Signature file with unexpected name

The created pull request registration had an unexpected file name like nickname.sig.tx instead of nickname.sig
Cases: #145

CI not finding the corresponding signature seems enough

Add CI check for valid commission #211 (comment)

done at 7cd3cb8