Make PHPCS in workflow show warnings

I've noticed that while PHPCS picks up warnings for me locally, it is not running on the workflow.

I see this is down to the -n in this line:

Line 31 in 588cde1

    
           run: phpcs --standard=../phpcs/Backdrop --report=.github/misc/Github.php -n --basepath=. *

@indigoxela - was there a particular reason to exclude warnings from the check?

I would personally prefer to have warnings display in the report and try to get all these addressed before the check passes. However, there does seem to be an option to show the warnings without failing the test:
https://github.com/squizlabs/PHP_CodeSniffer/wiki/Configuration-Options#ignoring-warnings-when-generating-the-exit-code

I think we could add into the command line with:

--runtime-set ignore_warnings_on_exit TRUE

What do you think?

was there a particular reason to exclude warnings from the check?

Nothing weird, just to not start too strict.

Sure, if you feel confident with it, turn warnings on. 👍

I've been working to this standard, and my original work included clearing warnings, so it would be good to maintain that.