backdrop-ops/contrib

Contrib Group Application: Egmund

Opened this issue · 14 comments

Egmund commented

Hello and welcome to the contrib application process! We're happy to have you :)

I would like to contribute a project

Based on your selection above, please provide the following information:

(option 1) The name of your module, theme, or layout
Boxton2

Post a link to your new Backdrop project under your own GitHub account (option 1)
https://github.com/Egmund/BackdropLayouts

If you have chosen option 2 or 1 above, do you agree to the Backdrop Contributed Project Agreement
YES

herbdool commented

Thanks @Egmund. I just saw this mentioned in Zulip. This looks ok. Do you wish to be mostly a code or a non-code contributor? If the former do you have more code examples we can look at?

stpaultim commented

I'll just point out that @Egmund was engaged with and provided some good feedback on the Zeever / Digital Agency projects.

  • ❤️1
Egmund commented

I have posted a few more layouts for BackdropCMS in my github space.
And I can easily 'convert' other core layouts with the split top footer.

stpaultim commented

It looks like you have done 3 so far:

https://github.com/Egmund?tab=repositories

I have yet to test these myself. I will try to do so soon. I'm not sure if it makes sense to release them as a pack of layout templates or release them individually.

Also, not sure if there is a better name. Maybe "Sutro 3Col Footer", "Boxton 3Col Footer" etc?

Egmund commented

I have one more to upload.
Yes, the names are not 'ideal'
I can also generate (further) instructions for how to use these for 'Digital Agency' if needed.

herbdool commented

Thanks @Egmund. I think there's enough to get approved. But I think @jenlampton or @klonos will need to give the final approval. I'm not sure if I can just do it on my own.

Egmund commented

Actually it is not that important to me. I made the layouts for myself, but Tim suggested I share them.
I do like BackdropCMS and want it to succeed. There are many 'challenges' for this and I am (also) working on translations into Danish for Backdrop as well as modules (but have nowhere to post the translations).

jenlampton commented

Thanks @Egmund, we appreciate you taking the time to give these back :)

Would you be open to putting both (or all, if you add more in the future) these layout templates into a single project? The best case scenario is when someone downloads and adds a single layouts project onto their website, and then they have a set several new layout templates to choose from.
Here's a great example: https://github.com/backdrop-contrib/juiced_up_layouts

New Project Checklist

All projects must meet these minimum requirements.

  • N/A Maintain the Git history from Drupal 7. See
    this article.
  • Include a README.md file that includes license and maintainer information.
    You can use this example.
  • Include a LICENSE.txt file that indicates the contributed code is GPL-2.0

We require some sections for the README.md file that are missing from yours, you can which are required by looking at our example file, here: https://raw.githubusercontent.com/backdrop-ops/contrib/master/examples/README.md

The LICENCE file you included is GPL version 3. Did you specifically choose version 3 over version 2? We request version 2 if possible (see https://github.com/backdrop-ops/contrib for more reasoning). If you are okay with switching to version 2, you can copy the example file provided for that too. Please end the file in .txt when you make the change, though this is far less important than the text within ;)

Egmund commented

I now have 'cleaned up my act', combined my layouts into one package, written a - hopefully - proper readme and changed license to ver 2.0
All is tested on one of my sites - functions as it should.

jenlampton commented
jenlampton commented

This layout templates project looks very useful, I've often wanted a 3-column footer. I might use this right away on one of my current projects :)

New Project Checklist

All projects must meet these minimum requirements.

  • N/A Maintain the Git history from Drupal 7. See this article.
  • Include a README.md file that includes license and maintainer information. You can use this example.
  • Include a LICENSE.txt file that indicates the contributed code is GPL-2.0

I've reviewed this project and since it meets all 3 requirements, an invitation to join the Backdrop Contrib group is on the way!

Once you have accepted the invitation, feel free to transfer the repository into the backdrop-contrib group at any time (ask here if you have questions).

I have one more very small request -- Before you transfer this repository to the contrib group, Could you please change the name to lowercase letters? Then it will match the files and functions within: https://github.com/Egmund/3-column-top-footer-layouts

Welcome to contrib, we are happy to have you!

Egmund commented

It is lowercased and transferred to Backdrop Contrib. Awaiting show-up on the 'Layouts' in BackdropCMS.

Feel free to 'steal' my idea for 'updating' core layouts.

  • ❤️1
Egmund commented

Hope I am not overlooking something. The layout package is now in the Backdrop Contrib 'space' for about 14 hours, but not on the layout server.

jenlampton commented

Hi @Egmund, the system is expecting the tag to start with 1.x -- with the dot . between 1 and x -- as soon as that is added you should be in good shape - but let us know here if you still have issues!

Sometimes, instead of a package you'll get an attachment labeled PACKAGING_ERRORS (or something) that will have more information. I'm not sure if that happened this time or not - maybe you've already seen it :)