backstage/community-plugins

๐Ÿ› mta: Unable to version bump to latest - 1.32.2

Closed this issue ยท 1 comments

Plugin Name

mta

๐Ÿ“œ Description

I've tried to version bump the mta plugin to the latest - 1.32.2 - but ran into deprecated and removed code being used. The changes to fix this will lead to breaking changes which I'm not sure how the author would like to best handle.

๐Ÿ‘ Expected behavior

We should be able to easily version bump the mta plugin

๐Ÿ‘Ž Actual Behavior with Screenshots

Unable to version bump the mta plugin: #1656

๐Ÿ‘Ÿ Reproduction steps

See: #1656

๐Ÿ“ƒ Provide the context for the Bug.

As part of routine maintenance we version bump the plugins in this repo. Most have very little issues with this beyond what is needed for a given release.

๐Ÿ‘€ Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

๐Ÿข Have you read the Code of Conduct?

Are you willing to submit PR?

No, but I'm happy to collaborate on a PR with someone else

Some notes from when I tried to resolve this. For scaffolder-backend-module-mta it uses the identity service which has been removed here:

But it's not actually used and this didn't come up before due to the use of any here:

export function createMTAApplicationAction(opts: any) {
const { config, logger } = opts;

Removing that should resolve the issues for this plugin. Now for mta-backend it is also using the identity service but I'm less sure what needs to be done to fix it as I don't know the plugin at all. It seems to be isolated to this one location though:

const backstageID = await identity.getIdentity({ request });

I think using the User Info Service would be the path forward: https://backstage.io/docs/backend-system/core-services/user-info/