backstage/community-plugins

🔧 Repository: Remove Janus IDP cli from multiple plugins

Closed this issue · 3 comments

christoph-jerolimov commented

📜 Description

When we, as Red Hat, contributed some of our backstage plugins to the community, we included a dependency to @janus-idp/cli and used this in the build process (the yarn export-dynamic scripts).

We want remove that dependency and align the build process with other plugins.

For this we want remove this dependency from this workspaces:

👍 Expected behavior

No @janus-idp/cli dependency and export-dynamic script in any workspace.

👎 Current Behavior

@janus-idp/cli dependency and export-dynamic script in some workspaces.

📃 Provide the context for the Bug.

The script was used to add additional build artifacts (the dist-scalprum folder) to the npm package:

https://www.npmjs.com/package/@backstage-community/plugin-redhat-argocd/v/1.10.0?activeTab=code

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

Yes I am willing to submit a PR!

04kash commented

@christoph-jerolimov can we have a checklist of all steps needed for this issue, this is what I'm thinking:

  • Delete the dist-dynamic folder.
  • In package.json, remove the export-dynamic and postinstall scripts, along with any other scripts referencing export-dynamic.
  • Remove @janus-idp/cli from dependencies.
  • Remove "dist-dynamic/", "dist-dynamic/dist/", and "dist-scalprum" entries from the files field in package.json.
  • Rename app-config.yaml to app-config-example.yaml.
christoph-jerolimov commented

@04kash That's the correct steps. My goal is to have that PRs for all the workspaces in the list above up by today.

  • 👍1
christoph-jerolimov commented

We might or might not cleanup also the redhat-argocd plugin. There are some internal discussions about the timing. So it might take some more time, but we can close this tracker already now.