backstage/community-plugins

🐛 git-release-manager: Can't promote RC

Opened this issue · 0 comments

mindthecap commented

Plugin Name

@backstage/plugin-git-release-manager

📜 Description

Can't promote Release Candidate with semantic versioning when i have created a second version with the plugin.

👍 Expected behavior

Release Candidate is promoted, branch with correct name is created and a release is created

👎 Actual Behavior with Screenshots

The problem is seen in the picture.
image

👟 Reproduction steps

  1. Create a semver RC
  2. Promote the RC
  3. Create another minor or major RC
  4. Can't promote the RC (no option)

📃 Provide the context for the Bug.

One can't set the pre-release as latest release when multiple releases exist. This code has a logic flaw:

community-plugins/workspaces/git-release-manager/plugins/git-release-manager/src/features/PromoteRc/PromoteRc.tsx

Line 39 in dfe7569

if (!latestRelease.prerelease) {

The promoteRC should fetch all RC releases and user should be able to chose which RC should be promoted.

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

No, but I'm happy to collaborate on a PR with someone else