backstage/community-plugins

๐Ÿ”ง Repository: tech-insights setup documentation incomplete

jackmtpt opened this issue ยท 13 comments

๐Ÿ“œ Description

https://github.com/backstage/community-plugins/blob/main/workspaces/tech-insights/plugins/tech-insights-backend/README.md

This readme contains some instructions for setting up tech-insights with the new backend, but not everything is covered e.g. how to register the fact checker.

๐Ÿ‘ Expected behavior

Everything should be documented for the new backend, and optionally for the old backend as well.

๐Ÿ‘Ž Current Behavior

Not everything has docs for the new backend

๐Ÿ‘Ÿ Reproduction steps

n/a

๐Ÿ“ƒ Provide the context for the Bug.

No response

๐Ÿ‘€ Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

๐Ÿข Have you read the Code of Conduct?

Are you willing to submit PR?

None

Contributions welcome ๐Ÿ‘

As soon as I figure out how to do it I can write something...

I'd love to know it as well how to do it, is the last plugin that I have in the old BE but I have a lot of custom checks to migrate.

I remember asking about this in Discord but I never had time to dig into it, this is part of what they replied:

The extension point is:

let factCheckerFactory:
  | FactCheckerFactory<TechInsightCheck, CheckResult>
  | undefined = undefined;
env.registerExtensionPoint(techInsightsFactCheckerFactoryExtensionPoint, {
  setFactCheckerFactory<
    CheckType extends TechInsightCheck,
    CheckResultType extends CheckResult,
  >(factory: FactCheckerFactory<CheckType, CheckResultType>): void {
    factCheckerFactory = factory;
  },
});

Where you can add your own fact check factory. That allows you to implement that interface with your own implementation.

and this is the link to the discord discussion :)

Working on updated documentation in #807. ๐Ÿ‘‹๐Ÿผ Feel free to provide feedback directly on the PR.