balancednetwork/balanced-contracts

Fee Handler integration testing

Closed this issue · 6 comments

BennyOptions commented

Deploy Fee Handler on testnet and ensure it works properly. Fee Handler was approved by vote with BIP6.

Fee Handler PR is #406

simusud commented

After merging fee handler updates, we are having problem while swapping the tokens. It says pool doesn't exist even though the pool exists in dex contract.

Skyvell commented

Checklist settings

Settings governance contract:

  • Register feehandler contract address.

Settings dex contract

  • Set feehandler contract address.

Settings feehandler contract

  • Set accepted dividends tokens.
  • Set routes.
  • Set fee-processing interval.

To me it sounds like there might be an issue with the routes in the feehandler contract. Just a guess though.
If the routes are incorrect/non-existent or there is a bug there, then it might cause the trades to fail since trades and feehandling is coupled.

simusud commented

i am setting route path for OMM fees as follows:
fromToken = OMM
toToken = bnUSD
path = [ sICX, bnUSD]

Example:
fromToken = "cx683c78174c740c3c6215de0c3ead1fad024324d6"
toToken = "cx041714d034919c8456d3606f8766f0169e35cb8e"
path = [
"cx0e706eca3552a6e607095319f4ad8cea37e779d4",
"cx041714d034919c8456d3606f8766f0169e35cb8e"
]

Is there any issue while defining routes ? @Skyvell
You can verify the routes i have defined in sejong :
https://sejong.tracker.solidwallet.io/contract/cx1e2ddb7bffd0bf8713878176f0754d6f89654a5b#readcontract

Skyvell commented

accepted_didivends_tokens looks fine.
fee_processing_interval looks fine.

You got the overall structure right for the route definition, but we want to convert to BALN, not bnUSD, right?

fromToken = OMM
toToken = BALN
path = [sICX, BALN]

Please let me know if you have more questions, or if defining the routes does not solve the issue.

simusud commented

Yeah, converting to BALN solved the issue . Thanks.