res.redirect() becomes an endless loop due to the fix of "lib/router/req.js" in 1.5.7

[HiroyukiNIshimura]

Node version:
Sails version (sails): 1.5.7
ORM hook version (sails-hook-orm):
Sockets hook version (sails-hook-sockets):
Organics hook version (sails-hook-organics):
Grunt hook version (sails-hook-grunt):
Uploads hook version (sails-hook-uploads):
DB adapter & version (e.g. sails-mysql@5.55.5):
Skipper adapter & version (e.g. skipper-s3@5.55.5):

---

for example
In the case of redirecting to "/main" with url: "/", it became an endless loop.

[sailsbot]

@HiroyukiNIshimura Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

• look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
• tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
• make sure you've provided clear instructions on how to reproduce the bug from a clean install.
• double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
• read the code of conduct.
• if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
• let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

---

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

[eashaw]

Hi @HiroyukiNIshimura, would you be able to share an example of the code where you are seeing this issue?

I tried reproducing this in a new Sails app with a socket request, and I was not able to.

[HiroyukiNIshimura]

Sorry for the late reply.

It occurs when using MCV instead of socket.

view-homepage-or-redirect.js

module.exports = {
  friendlyName: 'View homepage or redirect',

  description: 'Display or redirect to the appropriate homepage, depending on login status.',

  exits: {
    success: {
      statusCode: 200,
      description: 'Requesting user is a guest, so show the public landing page.',
      viewTemplatePath: 'pages/homepage',
    },

    redirect: {
      responseType: 'redirect',
      description: 'Requesting user is logged in, so redirect to the internal welcome page.',
    },
  },

  fn: async function () {
    if (this.req.me) {
      throw { redirect: `/main` };
    }

    return {};
  },
};

With this code, it happened when I accessed the URL for this action.

[HiroyukiNIshimura]

We have confirmed that the issue is resolved in 1.5.8 !