v0.3.0 breaks sails-postgresql
Closed this issue · 2 comments
As mentioned in balderdashy/sails-postgresql#147 (comment) (and balderdashy/sails-postgresql#151), updating sails-postgresql to wl-sequel 0.3.0 breaks 2 tests:
- Queryable Interface Modifiers greaterThanOrEqual (>=) strings should return records with greaterThanOrEqual key when searching strings;
- Queryable Interface Modifiers greaterThanOrEqual (>=) strings should return records with symbolic usage >= usage when searching strings.
Build results: https://travis-ci.org/balderdashy/sails-postgresql/jobs/58947819#L190
Reverting wl-sequel to 0.2.0 in balderdashy/sails-postgresql@c84872a makes the tests pass, meaning they got broken between 0.2 and 0.3.
@RWOverdijk, you made most (all?) of the code changes between 0.2 and 0.3, can you please take a look at this? Thanks.
PR #41 fixes this.
Fixed by #41, thanks @RWOverdijk!
Now we just need to release 0.3.1. @particlebanana we will need a waterline-sequel 0.3.1 release soon but you may want to wait until we get to the bottom of balderdashy/sails-postgresql#153: Tests broken on timezone Netherlands.