bamlab/react-native-image-resizer

Isn't `rotatedImage != rotatedImage` always true?

Closed this issue · 6 comments

retyui commented

Describe the bug

Hi bam engineers. can you explain how the next line should works

react-native-image-resizer/android/src/main/java/com/reactnativeimageresizer/ImageResizer.java

Lines 560 to 562 in 96721a2

if (rotatedImage != rotatedImage) {
sourceImage.recycle();
}

macksal commented

As an optimisation, it could be possible for rotateImage() to return the same Bitmap when rotation=0.

  • 😄1
0xc22b commented

Should it be rotatedImage != sourceImage?

  • 👍2
macksal commented

ha, you're right. I wonder if there's a memory leak because of this? Not sure if Bitmap.recycle is necessary to call or if it can still be GC'd

  • 👍1
taboulot commented

Hey !
Indeed I think it's not normal.
Will be fixed in this PR once merged : #398

taboulot commented

@retyui

I close this issue has it must be fixed in 3.0.10.

retyui commented

thx