bandframework/rose

Allow the user to provide their own high-fidelity solutions (BYOHFS).

Closed this issue · 4 comments

odell commented
Allow the user to provide their own high-fidelity solutions (BYOHFS).
odell commented

Right now, the emulator uses the rho mesh that the user supplies alongside their high-fidelity solutions. It must be equally spaced (so we can ignore the integration weights).

Should we interpolate the user-provided HF solutions onto our own rho mesh so that the user doesn't have to worry about their mesh's spacing? Or does this "destroy" the high-precisionness of the solutions they provided?

odell commented

This has been implemented on the byohfs branch. But the interface/workflow is not as smooth as it could be.

The user has to construct a CustomBasis object with their solutions and supply it to ReducedBasisEmulator. (Other relevant parameters are ignored by the emulator.)

Changes still need to be propagated "up" to ScatteringAmplitudeEmulator.

odell commented

Changes have been propagated "up" to ScatteringAmplitudeEmulator. The user can now supply a list of trained Basis instances.

Basis instances should also support save and load.

odell commented

Done. The user can now provide their own Basis instances which can also be saved and loaded. I'm closing this issue.