Snowhouse not bundled with v2.0.0 download
BardurArantsson opened this issue · 3 comments
Hi,
It seems that snowhouse is not bundled with bandit in the v2.0.0 download (I only tried the .tar.gz file). I'm guessing it has something to do with snowhouse being a submodule.
This predicably leads to errors when including bandit.h.
Perhaps it some release scripts (or some such) need updating?
That's a quirk of github, not bandit. Github automatically creates those archives when you create a release, but they won't include submodules. Apparently this is a known issue.
Download it with this instead:
git clone --recursive --branch v2.0.0 https://github.com/joakimkarlsson/bandit.git
Would it be worthwhile to manually add a full tarball to each release instead of relying on the auto-tarball? I think there's a way to get TravisCI to do that automatically, but I haven't looked at it in a while.
Alternatively, it would be handy to have the option to not require snowhouse when it's not being used. That would neatly sidestep this issue as well.
Right, it wasn't an issue for me per se (once I'd figured out what was wrong, that is), I just think it would be very confusing for any new users who might come along.
Perhaps it would be sufficient to add the "git clone" command to the release notes?