Point and click brand assignment via datasource admin panel
Closed this issue · 4 comments
When the datasource admin view suggests a brand to associate the datasource with, it should be possible to point and click to assign the datasource's foreign key with the brand
This is related to #5
This is finished.
I'm not considering this quite done because the bank suggestions are so out of whack. It seems like the lev function is comparing a bank's tag and datasource tags without model names. Effectively, it's comparing things like "fairfinance_rabobank" and "rabobank" and finding the distance is too high.
https://github.com/bank-green/bankgreen-django/blob/master/brand/models/brand.py#L258
Fix that bit and I'll pass it though.
I don't really understand this. What do I need to change? Shouldn't the script run that?
It seems like the lev function is comparing a bank's tag and datasource tags without model names
Should we compare bank tags and datasource tags even with the datasource model name in the front???
The line that you've pointed id deleting itself from the list.
Hey @skerdilajdhoxha - I may have misunderstood what's going on here, but from what I can see, a brand's suggested datasources don't have much to do with the datasource itself. In the image, you can see that fairfinance_rabobank's suggested datasource is shinkin_central_bank.
Could you fix the recommendations so that they make a bit more sense?
