banzaicloud/koperator

Envoy and Cruisecontrol are not having custom label config in the CRD.

saishivau opened this issue · 3 comments

Is your feature request related to a problem? Please describe.

I am not able to add custom labels to envoy and cruisecontrol pods via CRO.

Describe the solution you'd like to see
CRD file itself doesnt have the labels config defined in it.

Hi @saishivau,

I did a quick check and indeed currently there is no way to add customized labels to the Envoy and CruiseControl pods. Would you mind helping us with this minor feature implementation?

The implementation should be straightforward and you can refer to how the implementation customized annotations for both Envoy and CruiseControl:

Hi @panyuenlau,
Can you please check the pull request. I didnt test the implementation because I am not able to test locally.

Hi @panyuenlau, Can you please check the pull request. I didnt test the implementation because I am not able to test locally.

@saishivau Left some comments in the PR