banzaicloud/service-tools

Extraneous dependency: `request-promise-native`

Closed this issue ยท 1 comments

Overview of the Issue

This package includes a reference to the very sizable request-promise-native package under dependencies here, and is implemented as part of makeRequest helper function.

๐Ÿ‘‰ install size

The exported makeRequest helper function is not officially documented, and appears to be utilized only within unit test scripts.

Reproduce the Error

npm install
npm ls --prod | grep request-promise-native

Related Issues

N/A

Suggest a Fix

Without specific knowledge of the project roadmap for exposing such http helper functions, it may be worthwhile either installing under devDependencies or refactoring to use a more lightweight HTTP request package:

@mvandervliet you are totally right, I was exposing it to be used in other projects, but it shouldn't be a required dependency. Please review #2 if you have some time! Thank you!