Do we need to call Helmet.renderStatic() to avoid a memory leak?

Question

Do we need to call Helmet.renderStatic() to avoid a memory leak?

bherila opened this issue 8 years ago · 3 comments

It says in the README for Helmet under "Server usage":

Because this component keeps track of mounted instances, you have to make sure to call renderStatic on server, or you'll get a memory leak.

Do we need to do this somewhere in Vortigern?

Thanks,
Ben

Answer 1 · 2017-06-27T22:10:01.000Z

Turns out .rewind() is deprecated, per

https://github.com/nfl/react-helmet/blob/07851a670f2342161c128558f8e17cbffbd61dfd/CHANGELOG.md

we should change Helmet.rewind() to Helmet.renderStatic()

Answer 2 · 2017-07-03T20:11:58.000Z

Great catch. I'm still reading about Helmet. Not sure how to request admin to update master. I also think script clean should be renamed cleanbuild in package.json. I used yarn to run my stuff and entered "yarn clean" which incorrectly clean my source files.

Answer 3 · 2017-07-03T20:48:18.000Z

@TriStarGod yarn run clean should work, it works for me anyway.