barend/java-iban

IBAN for France : Branch setup to add

johannbart opened this issue · 3 comments

Hello,

thanks for this API, really appreciate !

The setup for France is incomplete.

You should add :

  • Bank 5 digits from 5 to 9 (already done)
  • Branch 5 digits from 10 to 14

Source 1 : https://fr.wikipedia.org/wiki/International_Bank_Account_Number
Source 2 : I am french. :-)

Thanks.

Hi, thanks for the improvement suggestion!

The reason the branch identifier is not there is because it's not listed in the official SWIFT IBAN Registry PDF [1], currently release 89 (page 30). What's interesting is that it does list the IBAN structure as FR2!n5!n5!n11!c2!n with both of the 5!n blocks, so it's kinda-sorta there, but it's not explicitly included in the structure table.

I originally started out with IBAN information from tons of different sources, and that got really confusing, so I'm now only using two (and that would have been one, but I didn't want to break compatibility). I suppose in this case it's clear enough, but I want to avoid taking my reference information from tons of diferent places again.

I'll leave this issue open for now and fix it when I bake the next release. I'm now one version behind the IBAN Registry, so I should do a maintaince release soon.

[1] https://www.swift.com/standards/data-standards/iban-international-bank-account-number

Thanks for the super fast feedback. :-)

@johannbart I have just released version 1.9.0 to Maven Central. It'll take a bit of time to drip through the CDN.