barisaydinoglu/Detectizr

missing version

Closed this issue · 7 comments

Nice tool, i like it very much. I missing a version number in the .js file. (Older files provides one)
And... can you also provide a minified version?

@hamburger123456 Do you mean a version in the filename or in the source itself?

just one to differentiate between older versions. It doesn't matter where. I prefer in source code.

You can find the version number in the package.json and bower.json files.
That's how NPM and Bower know which version to install.

On Wed, Aug 20, 2014 at 11:53 AM, Hamburger notifications@github.com
wrote:

just one to differentiate between older versions. It doesn't matter where.
I prefer in source code.


Reply to this email directly or view it on GitHub
#25 (comment)
.

Additionally, there are tagged versions under the releases section of any github repo https://github.com/barisaydinoglu/Detectizr/releases

I think I'am not the only one who is downloading only the *.js file from github. Doing this I have no chance to see later witch version it is.
In the script file is only this: Detectizr v@VERSION. Why not v2.0?

@hamburger123456 maybe not, but that isn't standard practice. You really should be using Bower to manage your JS packages rather than keeping them locally.

@hamburger123456 you should not use src/detectizr.js, it's only for development.
The distributed version of js file is under the Releases section and dist folder.