barseghyanartur/tld

Consider moving to google/pygtrie

Closed this issue · 2 comments

Consider moving to google/pygtrie

Why though? Would this make things easier for serialization? The lib's current Trie is tailored for your use case (regarding wildcards and public/private etc.).

@Yomguithereal:

It's just something to consider and certainly try (in a branch), as a potential improvement (speed up). If that one works remarkably faster, it wouldn't be wise not to. I haven't studied that library well enough to tell whether it would make serialisation simpler or not, but that would be a minor and doable thing anyway.