bartok765/galaxy_blizzard_plugin

login loop

Closed this issue · 14 comments

chrissix666 commented

I can successful login into the Battle.net, but after the login window closes ist states "offline - retry", i open the window again and can login.

  • Login successful
  • But the plugin always left behind "offline - retry"

I also deinstalled and re-installed the plugin several times, without success

elkangaroo commented

Thanks for your report @chrissix666, can you please check if there is any errors in the log file? You can find it here:

  • Windows: %programdata%\GOG.com\Galaxy\logs\plugin-battlenet-*.log
  • MacOS: /Users/Shared/GOG.com/Galaxy/Logs/plugin-battlenet-*.log
DuumXH commented

Same issue here. The only error i found is "DEBUG - Sending data: {"jsonrpc": "2.0", "id": "8", "error": {"code": 3, "message": "Backend timed out"}}"
I'll attach the log , maybe it will be useful.
plugin-battlenet-ba170431-0649-482f-863b-d248592f1842.log

  • 👍1
elkangaroo commented

Thanks for the log files, the "Backend timed out" is indeed causing this issue).
I am investigating now.

elkangaroo commented

The problem is, after login we send a request to https://eu.account.blizzard.com:443/oauth2/authorization/account-settings which currently times out (almost) always. Timeout is 10 seconds.
I could even reproduce it once on offical battle.net website after login. There seems to be some issues on blizzard servers.

@bartok765 As a workaround I increased the timeout in #36, do you think we can use this as a quick fix?

bartok765 commented

Yes, definitely. Is 20sec long enough?

elkangaroo commented
bartok765 commented

Merged. Just tried myself, and one time is below 10, another time more than 10.
I've pushed 1.3.1 version to fog_release branch. Leaving the issue open until @FriendsOfGalaxy merge it. Thanks @elkangaroo for quick check.

chrissix666 commented

I have no idea how to update the plugin myself (not a noob but less github experienced)

I just closed Gog Galaxy 2.0 & exchanged the 2 files you updated:
backend.py
http_client.py

Unfortunately it does not change anything, issue still persits.
Looking forward to an official bug fix realease

bartok765 commented

@chrissix666 what you've done should work. Drop your logs please - maybe there is different problem.

bartok765 commented

Update: I've doubled timeout to 40s as it was not enough for me as well.

Gliptal commented

I can confirm the latest 40s change fixes the problem.

chrissix666 commented

I can also confirm with the latest changes login is possble again with success. Great thanks, much appreciated!