baschte/content-animations

Animation is not applied if frame_class=none is set (easy fix)

Closed this issue · 1 comments

Sometimes you want to get rid of all margins/padding/spacings of a CE, so you disable the CE frame. Unfortunately the animationSettings are applied on this frame element (Tested with bootstrap_package v12, but probably will be the case for the other Layouts as well).

Suggested fix: in the else-case of the Layout file, add a simple wrapper div just containing the animationSettings, e.g.:

    <f:if condition="{data.frame_class} != none">
        <f:then>
          //...
        </f:then>
        <f:else>
            <div id="c{data.uid}" {f:if(condition: animationSettings, then: '{animationSettings -> f:format.raw()}')}>
            <f:if condition="{data._LOCALIZED_UID}">
                <a id="c{data._LOCALIZED_UID}"></a>
            </f:if>
            <f:if condition="{data.space_before_class}">
                <div class="{spaceBeforeClass}"></div>
            </f:if>
            <f:render section="Before" optional="true">
                <f:render partial="DropIn/Before/All" arguments="{_all}" />
            </f:render>
            <f:render section="Header" optional="true">
                <f:render partial="Header/All" arguments="{_all}" />
            </f:render>
            <f:render section="Main" optional="true" />
            <f:render section="Footer" optional="true">
                <f:render partial="Footer/All" arguments="{_all}" />
            </f:render>
            <f:render section="After" optional="true">
                <f:render partial="DropIn/After/All" arguments="{_all}" />
            </f:render>
            <f:if condition="{data.space_after_class}">
                <div class="{spaceAfterClass}"></div>
            </f:if>
            </div>
        </f:else>
    </f:if>

If you need this behaviour pls extend the layout in your Custom extension and add the needed div there.